svn commit: r341406 - head/devel/bncsutil-ghost++

[Baptiste Daroussin]

On Mon, Jan 27, 2014 at 02:20:52PM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 27, 2014 at 03:12:26PM +0100, Baptiste Daroussin wrote:
> > On Mon, Jan 27, 2014 at 02:08:36PM +0000, Alexey Dokuchaev wrote:
> > > On Mon, Jan 27, 2014 at 01:37:57PM +0000, Baptiste Daroussin wrote:
> > > > New Revision: 341406
> > > > URL: http://svnweb.freebsd.org/changeset/ports/341406
> > > > QAT: https://qat.redports.org/buildarchive/r341406/
> > > > 
> > > > +MAKE_ARGS=	PREFIX=${STAGEDIR}${PREFIX}
> > > 
> > > It would be nice (per our previous discussion) to briefly summarize in
> > > the commit log why, in the particular case, such construct is safe, as
> > > generally is is not.
> > 
> > Right; in that case I check that PREFIX is only used during the install
> > phase (in the upstream build process) I also checked that the install
> > process wasn't going to hardcode PREFIX somewhere. [...]
> 
> Baptiste, I know that you, as overall accurate committer, had done all
> the checking required to ensure that this construct, in this particular
> case is OK.  My point is that it better be briefly reflected in the log,
> as other, less careful or experienced folks might see it as "Oh, OK, I
> can simply set prefix to ${STAGEDIR}/${PREFIX} and be cone with it."
> 
Right, I'll do next time:)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140127/b8ce0659/attachment.sig>