svn commit: r341341 - head/devel/xwpe

[Baptiste Daroussin]

On Mon, Jan 27, 2014 at 10:36:54AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jan 27, 2014 at 11:22:31AM +0100, Baptiste Daroussin wrote:
> > This particular port is a bit special as the DESTDIR variable is already
> > defined it but for something totally different, thus I decided to inject a
> > variable named STAGEDIR instead that is why I defined DESTDIRNAME to
> > STAGEDIR in the makefile.
> 
> OK, fair enough. :)  Thanks for replying back.
> 
> > Your remark is valid is still valid for ports doing
> > --prefix=${STAGEDIR}${PREFIX} which is often wrong but not for those doing
> > --prefix=\$${STAGEDIR}${PREFIX} :)
> 
> I've just checked StageDir wiki page again; it seems that it already
> contains instructions on how to verify that STAGEDIR does not sneak inside
> the binaries (via bzgrep vs. my own handcrafted strings-based approach).

grep will say the binary matches, but sure it can be improved :)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140127/3387b1fc/attachment.sig>