svn commit: r340970 - head/devel/premake

[John Marino]

On 1/25/2014 10:14, Martin Wilke wrote:
> And your commenting about style worries maintainer and committers so
> better reread last line in motd at freefall. 
> 
> thanks ;)
> 
> 
> On Sat, Jan 25, 2014 at 2:46 PM, Alexey Dokuchaev <danfe at freebsd.org
>     Ditto.  Guys, I know some of you are working on stagifying the tree very
>     actively these days, making tens to hundreds commits a day.  This is all
>     much appreciated, cool, and awesome, but it does not mean commit
>     messages
>     can become sloppy.  Moreover, it gives a bad example for other people.

I agree that Danfe is coming from a weak position since he's throwing
stones while living in a glass house (meaning he's got plenty on his
plate and I don't see many commits lately), however, that doesn't make
him wrong.

The majority of FreeBSD commit messages are atrocious, and that's
including when they meet the standard of danfe.  I just love seeing QAT
message that you can't immediately tell which port failed because only a
very few people (like myself) put the name of the port being changed in
the first line of the message.

The freebsd rationale for not doing it?  "The mail list added the port
name automatically so it's redundant".  Except that doesn't apply to QAT
or any external repository.  So big fail all already.

So he's right + he should get his house in order to avoid the "shut up;
you're guilty too" responses.

John