svn commit: r340875 - head/graphics/py-pyglet

[Dmitry Marakasov]

* Mathieu Arnold (mat at FreeBSD.org) wrote:

> +--On 24 janvier 2014 01:25:38 +0000 Dmitry Marakasov <amdmi3 at FreeBSD.org>
> wrote:
> |  LIB_DEPENDS=	libfreetype.so:${PORTSDIR}/print/freetype2 \
> | -		libfontconfig.so:${PORTSDIR}/x11-fonts/fontconfig
> | +		libfontconfig.so:${PORTSDIR}/x11-fonts/fontconfig \
> | +RUN_DEPENDS=	${LOCALBASE}/lib/libavbin.so:${PORTSDIR}/multimedia/avbin
> 
> Hum, I think you have a \ too many.

My bad, sorry.

> |  post-install:
> | +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> | +	cd ${WRKSRC} && ${INSTALL_DATA} CHANGELOG NOTICE README
> | ${STAGEDIR}${DOCSDIR}/  	cd ${WRKSRC}/doc && ${COPYTREE_SHARE} .
> | ${STAGEDIR}${DOCSDIR}/
> |  	cd ${WRKSRC}/examples && ${COPYTREE_SHARE} . ${STAGEDIR}${EXAMPLESDIR}/
> 
> When doing cd foo && bar, you should always enclose it inside parenthesis,
> like this : (cd foo && bar) so that the following commands don't run in in
> a non default directory. (I know here it doesn't really matter right now
> because all the lines do cd, but it's a good habit to have.)

I don't think that matters unless ${WRKSRC} is deleted in the
process. Actually, it's even better, as if for some reason some
command leaves something behind (a corefile or a log) in it's current
directory, it'll end up in ${WRKSRC} and to a ports' directory.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru    http://www.amdmi3.ru