svn commit: r340118 - head/audio/lame

[Baptiste Daroussin]

On Fri, Jan 17, 2014 at 10:29:57PM +0000, Max Brazhnikov wrote:
> On Fri, 17 Jan 2014 21:41:12 +0000Fri Jan 17 21:41:12 2014 Alexander Leidinger wrote:
> > Author: netchild
> > Date: Fri Jan 17 21:41:12 2014
> > New Revision: 340118
> > URL: http://svnweb.freebsd.org/changeset/ports/340118
> > QAT: https://qat.redports.org/buildarchive/r340118/
> > 
> > Log:
> >   support stagedir
> >   
> >   PR:		185565
> >   Submitted by:	Takefu <takefu at airport.fm>
> > 
> > Modified:
> >   head/audio/lame/Makefile
> >   head/audio/lame/pkg-plist
> > 
> > Modified: head/audio/lame/Makefile
> > ==============================================================================
> > --- head/audio/lame/Makefile	Fri Jan 17 21:38:50 2014	(r340117)
> > +++ head/audio/lame/Makefile	Fri Jan 17 21:41:12 2014	(r340118)
> > @@ -11,16 +11,14 @@ MAINTAINER=	netchild at FreeBSD.org
> >  COMMENT=	Fast MP3 encoder kit
> >  
> >  USES=		gmake iconv
> > -NO_STAGE=	yes
> >  USE_AUTOTOOLS=	libtool
> >  USE_LDCONFIG=	yes
> >  GNU_CONFIGURE=	yes
> >  CONFIGURE_ARGS=	--enable-nasm --enable-mp3rtp --disable-gtktest
> > +CONFIGURE_ARGS_PREFIX=	${STAGEDIR}${PREFIX}
> 
> What's this?! Does it really do anything?
> 
No it doesn't at all :)

btw here is a patch to cleanup a bit that port:

http://people.freebsd.org/~bapt/lame.diff

it removes the noop "CONFIGURE_ARGS_PREFIX=	${STAGEDIR}${PREFIX}"
let the standard gmake install install everything, decomposing seems to bring
nothing more (no extra files installed or file missing)

Strip the binary library (DEVELOPER=yes passes thought stage-qa target which
shows that is it not stripped)

Always install the doc in the stage dir and let stage properly decided if it
will be install or not.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140117/bb869b91/attachment.sig>