svn commit: r338361 - in head/devel/silentbob: . files

[TAKATSU Tomonari]

2014/1/14 Alexey Dokuchaev <danfe at freebsd.org>:
> On Tue, Jan 14, 2014 at 10:14:19PM +0900, TAKATSU Tomonari wrote:
>> 2014/1/13 Alexey Dokuchaev <danfe at freebsd.org>:
>> Thank you for pointing out my mistakes.
>
> Thank you for taking my feedback constructively.
>
>> -.include <bsd.port.options.mk>
>> -
>
> This hunk is OK.
>
>>  post-patch:
>>         @${RM} ${WRKSRC}/CMakeCache.txt
>>         @${REINPLACE_CMD} -e
>> 's|/usr/lib/silent_bob/|${PREFIX}/lib/silent_bob/|' \
>>                 ${WRKSRC}/src/init.cxx
>
> Here we have a minor problem: REINPLACE_CMD statement is a bit too long, and
> causes a line wrap.  Would you consider this equivalent, but shorter version
> instead:
>
>         @${REINPLACE_CMD} -e '/lib\/silent_bob/s|/usr|${PREFIX}|' \
>                 ${WRKSRC}/src/init.cxx
>
> It also is more vocal: for lib/silent_bob, we change /usr into ${PREFIX},
> and reduces duplication ("silent_bob" is spelled only once).
>
>>  post-install:
>>         @${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -       @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
>> -.endif
>> +       ${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
>
> This part is OK.
>
> ./danfe

Thank you for your advice.
I'll commit with the improvement of the REINPLACE_CMD statement.

-- 
TAKATSU Tomonari