svn commit: r338572 - head/games/palomino

Rusmir Dusko nemysis at FreeBSD.org
Mon Jan 13 10:42:04 UTC 2014


> On Fri, Jan 03, 2014 at 06:59:38PM +0000, Rusmir Dusko wrote:
> > New Revision: 338572
> > URL: http://svnweb.freebsd.org/changeset/ports/338572
> > 
> > -DESKTOP_ENTRIES=	"Palomino" "${COMMENT}" "${PORTNAME}" \
> > -			"${PORTNAME}" "Game;ArcadeGame;" false
> > +DESKTOP_ENTRIES=	"Palomino" "" "${PORTNAME}" \
> > +			"${PORTNAME}" "Game;ArcadeGame;" ""  

> I've noticed you've removed "${COMMENT}" from DESKTOP_ENTRIES in some recent
> commits; could you elaborate on it a bit?  Most of the usage examples in the
> tree seem to include "${COMMENT}"...

In my earlier email correspondence with makcs regarding DESKTOP_ENTRIES,
he stated some interesting arguments, as to why would one, do so.

This is from his last email:

> I suppose you simply removed 'false', so that DESKTOP_ENTRIES had only 5 elements.
> If you need empty field, you shall use double quotes (""), e.g:

> DESKTOP_ENTRIES=	"Name" "" "Icon" "Exec" "Categories" ""

> This desktop entry will use ports ${COMMENT} for second field, and empty
> StartupNotify field.

> You may want to look description for DESKTOP_ENTRIES in Mk/bsd.port.mk.
> It covers more cases than Porters Handbook.

http://www.freebsd.org/doc/en/books/porters-handbook/using-x11.html#desktop-entries

Having that in mind, I removed "${COMMENT}" from DESKTOP_ENTRIES in some recent
commits.

-- 
Best regards,
Rusmir Dusko


More information about the svn-ports-all mailing list