svn commit: r337932 - head/comms/ebook2cw

[Alexey Dokuchaev]

On Sun, Dec 29, 2013 at 12:33:18AM +0000, Diane Bruce wrote:
> New Revision: 337932
> URL: http://svnweb.freebsd.org/changeset/ports/337932
> 
>  do-install:
> -	@${INSTALL_SCRIPT} ${WRKSRC}/ebook2cw ${PREFIX}/bin/ebook2cw
> -	@${INSTALL_DATA} ${WRKSRC}/ebook2cw.1 ${MANPREFIX}/man/man1
> -.if !defined(NOPORTEXAMPLES)
> -	@${MKDIR} ${EXAMPLESDIR}
> +	@${INSTALL_SCRIPT} ${WRKSRC}/ebook2cw ${STAGEDIR}${PREFIX}/bin/ebook2cw
> +	@${INSTALL_DATA} ${WRKSRC}/ebook2cw.1 ${STAGEDIR}${PREFIX}/man/man1
> +	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
>  .for 	f in ebook2cw.conf isomap.txt utf8map.txt
> -	@${INSTALL_DATA} ${WRKSRC}/$f ${EXAMPLESDIR}/$f
> +	@${INSTALL_DATA} ${WRKSRC}/$f ${STAGEDIR}${EXAMPLESDIR}/$f
>  .endfor
> -.endif
> -.if     !defined(NOPORTDOCS)
> -	@${MKDIR} ${DOCSDIR}
> -	@${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
> -.endif
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	@${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}

This is an example of badly written do-install recipe: all commands are
muted.  It would look like nothing is being installed (for a user building
from port), and produce crippled build logs, making debugging any install-
time problems harder.

As a general rule, we do not mute installation commands (INSTALL_FOO, CP,
LN, COPYTREE, etc).  Muting MKDIR's is fine and is more matter of personal
preference.

./danfe