svn commit: r339550 - in head/Mk: . Uses

[Baptiste Daroussin]

On Mon, Jan 13, 2014 at 01:20:34AM +0100, Baptiste Daroussin wrote:
> On Sun, Jan 12, 2014 at 09:16:06PM +0000, Chris Rees wrote:
> > Author: crees
> > Date: Sun Jan 12 21:16:06 2014
> > New Revision: 339550
> > URL: http://svnweb.freebsd.org/changeset/ports/339550
> > 
> > Log:
> >   Strip postgresql code out of bsd.database.mk, and introduce USES=pgsql.
> >   
> >   New syntax:
> >   
> >   # Depend on postgresql-client
> >   USES=	pgsql
> >   
> >   # Depend on postgresql-client at least 9.2
> >   USES=	pgsql:9.2+
> >   
> >   #Depend on postgresql-server at least 9.0
> >   USES=		pgsql:9.0+
> >   WANT_PGSQL=	server
> >   
> >   Postgresql now supports DEFAULT_VERSIONS, and please note that the
> >   version syntax now includes dots(!); i.e. before it was 90, now 9.0
> >   
> >   Reviewed by:	ade, silence from pgsql@
> > 
> 
> It is broken in multiple parts first WANT_PGSQL is checked even when not defined
> resulting multiple lines like:
> /usr/ports/Mk/Uses/pgsql.mk" line 128: Malformed conditional (${WANT_PGSQL:M${:Ucontrib}})
> if a port only defines USES=pgsql
> 
> If the first is fixed then the version is not properly defined resulting in a
> dependency like:
> /usr/ports/databases/postgresql-client which doesn't exists.
> 
> For this kind of change a portmgr review would have been nice and an exp-run
> even better.

Yet more things: there is mess up between what should be run in pre or post
section which is normally one of the things USES should solve and makes Mk/*
inefficient and lots of the time not predictable this is a major pain when
debugging.

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140113/cedbfac1/attachment.sig>