svn commit: r338284 - head/comms/gnocky

[Antoine Brodin]

On Thu, Jan 9, 2014 at 12:03 PM, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Tue, Dec 31, 2013 at 12:27:58PM +0000, Antoine Brodin wrote:
>> New Revision: 338284
>> URL: http://svnweb.freebsd.org/changeset/ports/338284
>>
>> -.if ${PORT_OPTIONS:MNLS}
>> -USES+=               gettext
>> -PLIST_SUB+=  NLS=""
>> -.else
>> -CONFIGURE_ARGS+=     --disable-nls
>> -PLIST_SUB+=  NLS="@comment "
>> -.endif
>> +OPTIONS_SUB= yes
>> +NLS_USES=    gettext
>> +NLS_CONFIGURE_ENABLE=        nls
>
> Why not just NLS_CONFIGURE_OFF= --disable-nls?  It looks like NLS support is
> on by default, and NLS_CONFIGURE_OFF saves passing explicit --enable-nls to
> the args (thus making them shorter).


Hello,

NLS_CONFIGURE_ENABLE=nls is 7 characters less than
NLS_CONFIGURE_OFF=--disable-nls
So it makes the Makefile shorter.

Cheers,

Antoine