svn commit: r338802 - in head/textproc: docbook-241 docbook-300 docbook-310 docbook-400 docbook-410 docbook-440 docbook-450 docbook-500 docbook-xml-450

Mathieu Arnold mat at FreeBSD.org
Mon Jan 6 14:22:08 UTC 2014


+--On 5 janvier 2014 17:21:23 +0000 Jason Helfman <jgh at FreeBSD.org> wrote:
| Log:
|   - fix pkgname collisions
| -LATEST_LINK=	docbook-241
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	docbook-300
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	docbook-310
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	docbook-400
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	docbook-410
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	${PORTNAME}-440
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	${PORTNAME}-450
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}
| -LATEST_LINK=	${PORTNAME}-500
| +PKGNAMESUFFIX=	${PKGORIGIN:T:S/docbook-//}

Why the overly complicated computation where you could just have put the
number that was in the LATEST_LINK right away ?
Those ports version will never change, so it's not likely that anyone will
ever have to update the PKGNAMESUFFIX.

| -LATEST_LINK=	${PORTNAME}-450
| +PKGNAMESUFFIX=	${PORTVERSION:S/.//}
| -LATEST_LINK=	${PORTNAME}-440
| +PKGNAMESUFFIX=	${PORTVERSION:S/.//}

And there, why the change of heart ? Now, we have a package named
docbook440 and one named docbook-xml44, which is rather not consistent at
all.

Regards,

-- 
Mathieu Arnold


More information about the svn-ports-all mailing list