svn commit: r346570 - head/mail/squirrelmail

[Adam Weinberger]

On 28 Feb 2014, at 14:54, Tijl Coosemans wrote:

> On Fri, 28 Feb 2014 19:28:24 +0000 (UTC) Adam Weinberger wrote:
>> 	${CHMOD} 730 ${STAGEDIR}${SQUIRRELDIR}/attach
>> 	${CHMOD} 750 ${STAGEDIR}${SQUIRRELDIR}/data
>
> I think you can remove the chmod commands too...
>
>
>> Modified: head/mail/squirrelmail/pkg-plist
>> ==============================================================================
>> --- head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:14:42 
>> 2014	(r346569)
>> +++ head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:28:23 
>> 2014	(r346570)
>> @@ -1,5 +1,7 @@
>> etc/periodic/daily/111.clean-squirrelmail
>> %%SQUIRRELDIR%%/attach/.htaccess
>> + at exec chown %%SMUSER%%:%%SMGROUP%% %B
>> + at exec chmod 730 %B
>
> ...if you do this as follows:
>
> @owner %%SMUSER%%
> @group %%SMGROUP%%
> @mode 730
> %%SQUIRRELDIR%%/attach/.htaccess
> @owner
> @group
> @mode
>
> Are you sure that 3 for group permissions is correct?
>
>> + at exec chown %%SMUSER%%:%%SMGROUP%% %B
>> + at exec chmod 750 %B
>
> Same here, but you could also group it with the .htaccess file above.
>
> The pkg-plist format is explained in the pkg-create manpage by the 
> way.

%B refers to the dirname. Your suggestion would change the ownership and 
permissions of the .htaccess file, which would then require an @exec 
chown and @exec chmod to repair, so it wouldn't really fix anything.

# Adam


--
Adam Weinberger
adamw at adamw.org
http://www.adamw.org