svn commit: r345514 - head/Mk/Uses

[Bryan Drewery]

On 2/21/2014 1:30 PM, Baptiste Daroussin wrote:
> On Fri, Feb 21, 2014 at 07:49:49PM +0100, Tijl Coosemans wrote:
>> On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote:
>>> Author: bapt
>>> Date: Fri Feb 21 16:47:29 2014
>>> New Revision: 345514
>>> URL: http://svnweb.freebsd.org/changeset/ports/345514
>>> QAT: https://qat.redports.org/buildarchive/r345514/
>>>
>>> Log:
>>>   libtool 1.4.2a was defining the shared extension as shrext_cmds, rename it shared_ext
>>>   like in newer libtool so the rest of USES=iconv magic just works
>>>
>>> Modified:
>>>   head/Mk/Uses/libtool.mk
>>>
>>> Modified: head/Mk/Uses/libtool.mk
>>> ==============================================================================
>>> --- head/Mk/Uses/libtool.mk	Fri Feb 21 16:04:38 2014	(r345513)
>>> +++ head/Mk/Uses/libtool.mk	Fri Feb 21 16:47:29 2014	(r345514)
>>> @@ -22,7 +22,8 @@ patch-libtool:
>>>  		-e '/link_all_deplibs[0-9A-Z_]*=/s/=unknown/=no/'	\
>>>  		-e '/objformat=/s/echo aout/echo elf/'			\
>>>  		-e "/freebsd-elf\\*)/,/;;/ {				\
>>> -		    /deplibs_check_method=/s/=.*/=pass_all/; }"
>>> +		    /deplibs_check_method=/s/=.*/=pass_all/; }"		\
>>> +		-e "s/shrext_cmds/shared_ext/g"
>>>  
>>>  .if ! ${libtool_ARGS:Moldver}
>>>  	@${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \)	\
>>
>> Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use
>> only one name.  shrext_cmds is defined by configure (normally just .so
>> for us) or by libtool when invoked with -shrext some_extension.  Then
>> later libtool defines shared_ext using 'eval shared_ext=\"$shrext_cmds\"'.
>>
>> What port does this fix?
> 
> devel/libghthash is the port broken if you end up with a better fix, please just
> commit.
> 
> Thank you
> Bapt
> 

This was causing libraries to build without .so, I have reverted for now.

Note:

> ===>  Checking if sysutils/hal already installed
> ===>   Registering installation for hal-0.5.14_23
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal-storage.a): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal-storage.la): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal-storage.so): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal-storage.so.1): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal-storage.so.1.0.0): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal.so): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal.so.1): No such file or directory
> pkg-static: lstat(/usr/ports/sysutils/hal/work/stage/usr/local/lib/libhal.so.1.0.0): No such file or directory
> *** Error code 74 (continuing)
> `/usr/ports/sysutils/hal/work/.install_done.hal._usr_local' not remade because of errors.

and

> libtool: install: /usr/bin/install -c -o root -g wheel .libs/liblogging-stdlog.0.0.0 /wrkdirs/usr/ports/devel/liblogging/work/stage/usr/local/lib/liblogging-stdlog.0.0.0



-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 553 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20140221/0ea2a7d3/attachment-0001.sig>