svn commit: r344308 - in head/multimedia/handbrake: . files

[Juergen Lock]

On Sat, Feb 15, 2014 at 07:13:49PM +0100, Alexander Leidinger wrote:
> On Fri, 14 Feb 2014 22:52:07 +0100
> Juergen Lock <nox at jelal.kn-bremen.de> wrote:
> 
> > On Fri, Feb 14, 2014 at 10:32:35PM +0100, Juergen Lock wrote:
> > > On Fri, Feb 14, 2014 at 08:00:14PM +0000, Thomas Zander wrote:
> > > > Author: riggs
> > > > Date: Fri Feb 14 20:00:13 2014
> > > > New Revision: 344308
> > > > URL: http://svnweb.freebsd.org/changeset/ports/344308
> > > > QAT: https://qat.redports.org/buildarchive/r344308/
> > > > 
> > > > Log:
> > > >   - Update port to upstream release 0.9.9
> > > >   - Stagify
> > > >   - USES cleanups
> > > >   
> > > >   PR:		ports/186387
> > > >   Submitted by:	Arjan Gijsberts <arjan at liralab.it>
> > > >   Approved by:	jadawin (co-mentor)
> > > > 
> > > > Added:
> > > > [...]
> > > 
> > > I just tried this and got:
> > > 
> > > [...]
> > > cc -pipe -fmessage-length=0 -Wall -g0 -O3 -O2 -pipe
> > > -fno-strict-aliasing -D__LIBHB__ -DUSE_PTHREAD -DSYS_FREEBSD
> > > -I./libhb/ -I/usr/local/include -I./contrib/include
> > > -I/usr/local/include -c ../libhb/muxcommon.c -o libhb/muxcommon.o
> > > cc -pipe -fmessage-length=0 -Wall -g0 -O3 -O2 -pipe
> > > -fno-strict-aliasing -D__LIBHB__ -DUSE_PTHREAD -DSYS_FREEBSD
> > > -I./libhb/ -I/usr/local/include -I./contrib/include
> > > -I/usr/local/include -c ../libhb/deca52.c -o
> > > libhb/deca52.o ../libhb/deca52.c:393:63: error: incomplete
> > > definition of type 'struct a52_state_s' (double)pv->state->slev,
> > > ~~~~~~~~~^ /usr/local/include/a52dec/a52.h:33:16: note: forward
> > > declaration of 'struct a52_state_s' typedef struct a52_state_s
> > > a52_state_t; ^ 1 error generated. [...]
> > > 
> > >  Will now run in poudriere to confirm...
> > > 
> > ..and that was better, sorry for the noise.
> 
> Not noise at all... this is a real problem. And it's not the only one.
> 
> If you have faac, liba52 and x264 installed, it fails to build (at
> least those are the ones I noticed because I have them installed). This
> is because it uses it's own version of them and fails because the ones
> in the ports tree don't match what is expected. For all except x264 the
> problems are compile problems, for x264 it is a link-problem.
> 
Ah, classic case of picking up wrong includes/libs i.e. wrong -I
-L order?  I think the previous xbmc version also suffered from
something like that, i.e. it didn't build outside tb/powderkeg...
(The current one seeems better tho.)

 I guess upstream often ignores these issues because Linux users
rarely build things locally, they all use prebuilt packages...
Or maybe it's also aggravated by our need for -I${LOCALBASE}/include
etc that can get added in the wrong position.

 Anyway, I'm glad my new box runs poudriere quite nicely... :)

	Juergen