svn commit: r343457 - head/audio/p5-Shout

[Emanuel Haupt]

Mathieu Arnold <mat at FreeBSD.org> wrote:
> +--On 9 février 2014 14:37:56 +0100 Emanuel Haupt <ehaupt at FreeBSD.org>
> wrote:
> |> Yes, and like the wiki[1] says, unless there's a tremendous number
> |> of files and the IO hit is pretty severe you should install them
> |> always.
> | 
> | So you agree with me that the inclusion is required?
> 
> Nope, the opposite. The wiki says: "The DOCS/EXAMPLES .if blocks can
> be made unconditional, except in cases when installed files are big
> enough to cause significant I/O overhead." 
> 
> In that case, you should have removed the conditional install of the
> files, so that they always get staged, and save make of having to
> parse bsd.port.mk twice :-)

I think you're confused, please look at the Makefile. This is _exactly_
what I made :-)

> |> (Also, if those are examples, they should go in EXAMPLESDIR)
> | 
> | I was simply looking at the aspect of converting the port to support
> | staging. I don't know if the application requires the files to be
> | installed in EXAMPLESDIR or DOCSDIR.
> 
> If they're manually installed by the port, that is, not needed, and
> they're called example* you can safely assume that they're examples,
> and thus, need to go into the examples directory :-)

I wouldn't be so sure. Manual installations in post-install sections
are often a result of broken Makefiles. You might be right here but
maybe not. All I'm saying is that I do not know for sure as I don't
know the application (port) good enough to make this decision.

Emanuel