svn commit: r343457 - head/audio/p5-Shout

[Emanuel Haupt]

Mathieu Arnold <mat at FreeBSD.org> wrote:
> +--On 9 février 2014 13:16:26 +0100 Emanuel Haupt <ehaupt at FreeBSD.org>
> wrote:
> | Mathieu Arnold <mat at FreeBSD.org> wrote:
> |> 
> |> 
> |> +--On 9 février 2014 11:01:36 +0000 Emanuel Haupt
> |> <ehaupt at FreeBSD.org> wrote:
> |> | +.include <bsd.port.options.mk>
> |> | +
> |> |  post-install:
> |> | -.ifndef(NOPORTDOCS)
> |> | -	@${MKDIR} ${DOCSDIR}
> |> | -	${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${DOCSDIR}
> |> | -.endif
> |> | +	${STRIP_CMD} ${STAGEDIR}
> |> | ${SITE_PERL}/${PERL_ARCH}/auto/Shout/Shout.so
> |> | +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> |> | +	${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> |> | ${DOCSDIR} 
> |> |  .include <bsd.port.mk>
> |> 
> |> What do you need bsd.port.options.mk for ?
> | 
> | I think it's required for dealing with the conditional installation
> | of:
> | 
> |         ${MKDIR} ${STAGEDIR}${DOCSDIR}
> |         ${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> | ${DOCSDIR}
> 
> Yes, and like the wiki[1] says, unless there's a tremendous number of
> files and the IO hit is pretty severe you should install them always.

So you agree with me that the inclusion is required?

> (Also, if those are examples, they should go in EXAMPLESDIR)

I was simply looking at the aspect of converting the port to support
staging. I don't know if the application requires the files to be
installed in EXAMPLESDIR or DOCSDIR.

Emanuel