svn commit: r342296 - in head/games/gnurobots: . files

Rusmir Dusko nemysis at FreeBSD.org
Wed Feb 5 11:14:43 UTC 2014


> * Rusmir Dusko (nemysis at FreeBSD.org) wrote:

>   - Disable all warnings with -w  

> Why? These should be fixed upstream and never silenced.

Because Upstream no longer maintains these Sources. The last is from
2008 and some patches that do not work from 2009.

Please look

http://git.savannah.gnu.org/gitweb/?p=gnurobots.git;a=summary

This I have seen before but these patches do not fix anything...


Does not actually fix anything

2009-11-18 	Bradley Smith	Fix autoconf mess such that you can actually specify...


This have some fixes which do not help for deprecated messages for old GTK code

2009-11-18 	Bradley Smith	Fix issues when compiling with optimisations.


I have added to test


src/grobot.c

@${REINPLACE_CMD} -e 's|gint dx, dy;|gint dx = 0, dy = 0;|' \
    ${WRKSRC}/src/grobot.c


src/main.c

files/patch-src__main.c

/usr/local/ports/local/In-Review/games/gnurobots/ > cat files/patch-src__main.c
--- ./src/main.c.orig   2008-08-03 17:19:46.000000000 +0200
+++ ./src/main.c        2014-02-05 11:27:35.000000000 +0100
@@ -282,6 +282,7 @@
        gchar *map_file = argv[1];
        gchar *robot_program = argv[2];
        gboolean loading = TRUE;
+       volatile gboolean *ploading = &loading;
 
        api_init();
 
@@ -304,7 +305,7 @@
                G_ROBOT_POSITION_X(robot), ROBOT);
 
        g_printf("Loading GTK Interface ... Please wait\n\n");
-       while(loading);
+       while(*ploading);
 
        /* Now initialize the rest of the Robot properties */
        g_object_set(G_OBJECT(robot),


Sorry for my bad English.

-- 
Best regards,
Rusmir Dusko


More information about the svn-ports-all mailing list