svn commit: r341828 - in head/www: nginx nginx-devel

[Bernhard Fröhlich]

Hi Sergey,

The default options are under discussion since the early beginnings of pkgng
which is quite a few years already. The first time I hward people complaining
about nginx SSL option for _me_ was on the DevSummit in Warsaw during the
Ports slot. Feel free to dig up an video on youtube to find the exact moment.

I'm pretty sure that you as the maintainer of nginx have heard about that
before so I see no benefit in looking up the history of the last 3 years just to
prove my point. Feel free to talk to bapt, erwin, bdrewery or other people from
portmgr that are on conferences regularly and you will see this is an recurring
topic.

Since I haven't heard any complains about that change yet, and you did not
provide any reasons except "I want you to revert" I do not plan to revert that
change right now. In fact the only responses so far that I got were positive.

I'm still open for technical discussions on that topic.


On Wed, Feb 5, 2014 at 3:05 AM, Sergey A. Osokin <osa at freebsd.org> wrote:
> Hi Bernard,
>
> could you provide "requests from many people over a long time", problem
> reports, letter, etc.?
>
> Again, I'm waiting when you revert back the changes.
>
> Thanks.
>
> --
> ozz
>
> On Sun, Feb 02, 2014 at 08:01:03AM +0100, Bernhard FrЖhlich wrote:
>> Hello Sergey,
>>
>> Is there a specific reason why you want it to be reverted? The change was
>> discussed on portmgr before it was committed and there is no need to have
>> an explicit approval from you.
>>
>> The change was requested by many people over a long time even on a few
>> conferences so it was about time to enable it per default. I even contacted
>> you upfront asking for technical advise and did send you an answer about
>> your USE_OPENSSL related wishes. After consideration by multiple people on
>> portmgr we felt it is good to proceed so I've done the commit.
>>
>> Am 02.02.2014 03:34 schrieb "Sergey A. Osokin" <osa at freebsd.org>:
>> >
>> > Please revert back this change, I didn't approve it.
>> >
>> > --
>> > Sergey A. Osokin
>> > osa at FreeBSD.org
>> >
>> > On Thu, Jan 30, 2014 at 10:01:52AM +0000, Bernhard Froehlich wrote:
>> > > Author: decke
>> > > Date: Thu Jan 30 10:01:51 2014
>> > > New Revision: 341828
>> > > URL: http://svnweb.freebsd.org/changeset/ports/341828
>> > > QAT: https://qat.redports.org/buildarchive/r341828/
>> > >
>> > > Log:
>> > >   - By popular request enable HTTP_SSL option per default
>> > >
>> > >   With hat:   portmgr
>> > >   Discussed with:     osa@ (maintainer)
>> > >
>> > > Modified:
>> > >   head/www/nginx-devel/Makefile
>> > >   head/www/nginx/Makefile
>> > >
>> > > Modified: head/www/nginx-devel/Makefile
>> > >
>> ==============================================================================
>> > > --- head/www/nginx-devel/Makefile     Thu Jan 30 09:45:42 2014
>>  (r341827)
>> > > +++ head/www/nginx-devel/Makefile     Thu Jan 30 10:01:51 2014
>>  (r341828)
>> > > @@ -3,6 +3,7 @@
>> > >
>> > >  PORTNAME=    nginx
>> > >  PORTVERSION= 1.5.8
>> > > +PORTREVISION=        1
>> > >  CATEGORIES=  www
>> > >  MASTER_SITES=        http://nginx.org/download/
>> > >  MASTER_SITES+=       ${MASTER_SITE_LOCAL}
>> > > @@ -105,7 +106,7 @@ OPTIONS_DEFINE=   \
>> > >
>> > >  OPTIONS_SINGLE=              VIDEO
>> > >  OPTIONS_SINGLE_VIDEO=        HTTP_MP4 HTTP_MP4_H264
>> > > -OPTIONS_DEFAULT=     IPV6 HTTP HTTP_CACHE HTTP_REWRITE HTTP_STATUS WWW
>> > > +OPTIONS_DEFAULT=     IPV6 HTTP HTTP_CACHE HTTP_REWRITE HTTP_SSL
>> HTTP_STATUS WWW
>> > >
>> > >  DEBUGLOG_DESC=                       Enable debug log (--with-debug)
>> > >  FILE_AIO_DESC=                       Enable file aio
>> > >
>> > > Modified: head/www/nginx/Makefile
>> > >
>> ==============================================================================
>> > > --- head/www/nginx/Makefile   Thu Jan 30 09:45:42 2014        (r341827)
>> > > +++ head/www/nginx/Makefile   Thu Jan 30 10:01:51 2014        (r341828)
>> > > @@ -3,7 +3,7 @@
>> > >
>> > >  PORTNAME=    nginx
>> > >  PORTVERSION= 1.4.4
>> > > -PORTREVISION=        2
>> > > +PORTREVISION=        3
>> > >  PORTEPOCH=   1
>> > >  CATEGORIES=  www
>> > >  MASTER_SITES=        http://nginx.org/download/
>> > > @@ -106,7 +106,7 @@ OPTIONS_DEFINE=   \
>> > >
>> > >  OPTIONS_SINGLE=              VIDEO
>> > >  OPTIONS_SINGLE_VIDEO=        HTTP_MP4 HTTP_MP4_H264
>> > > -OPTIONS_DEFAULT=     IPV6 HTTP HTTP_CACHE HTTP_REWRITE HTTP_STATUS WWW
>> > > +OPTIONS_DEFAULT=     IPV6 HTTP HTTP_CACHE HTTP_REWRITE HTTP_SSL
>> HTTP_STATUS WWW
>> > >
>> > >  DEBUGLOG_DESC=                       Enable debug log (--with-debug)
>> > >  FILE_AIO_DESC=                       Enable file aio



-- 
Bernhard Fröhlich
http://www.bluelife.at/