svn commit: r342510 - head/games/cutemaze
Max Brazhnikov
makc at freebsd.org
Tue Feb 4 14:36:42 UTC 2014
On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote:
> +--On 4 février 2014 13:05:39 +0000 Max Brazhnikov <makc at freebsd.org>
> wrote:
> |
> | This part should be reverted.
> | Folks, please *review* what makeplist generates and don't commit it
> | blindly.
>
> I for one would love to have feedback on what the evolved makeplist should
> do better :-)
It's way too aggressive for PLIST_SUB and this leads to false substitutions
sometimes. bsd.qt.mk defines a number of QT_*DIR, but not all of them should
be used (actually it depends on particular port).
We could help makeplist by telling explicitly which substitutions are right,
e.g. by specifying OPTIONS_SUB.
Max
More information about the svn-ports-all
mailing list