svn commit: r327791 - in head/graphics/eos-movrec: . files

Alexey Dokuchaev danfe at FreeBSD.org
Mon Sep 23 08:58:24 UTC 2013


On Mon, Sep 23, 2013 at 10:50:55AM +0200, Tijl Coosemans wrote:
> On Mon, 23 Sep 2013 06:49:49 +0000 Alexey Dokuchaev wrote:
> > I've just checked on my tindy, it builds fine with my original USE_QT4
> > value.  However, it does not package, as pkg-plist was missed in the
> > commit.
> 
> It does look excessive.  CMakeLists.txt only has:
> find_package(Qt4 4.4.2 COMPONENTS QtCore QtGui REQUIRED)

Right, same as when I first added it.  I honestly do not understand how
this USE_QT4 change was committed after few eyes supposedly reviewed it.
Not just it contains tons of Qt4 bloat, and does not match find_package(),
but apparently no one ever asked themselves, "why a simple movie capture
program needs qt4-webkit?". :(

./danfe


More information about the svn-ports-all mailing list