svn commit: r332953 - head/benchmarks/nttcp

Alexey Dokuchaev danfe at FreeBSD.org
Wed Nov 6 08:18:15 UTC 2013


On Wed, Nov 06, 2013 at 08:11:37AM +0000, Ganael LAPLANCHE wrote:
> New Revision: 332953
> URL: http://svnweb.freebsd.org/changeset/ports/332953
> 
> @@ -14,15 +14,13 @@ COMMENT=	A client/server program for tes
>  RESTRICTED=	No commercial use
>  
>  ALL_TARGET=	nttcp
> -MAN1=		nttcp.1
> -PLIST_FILES=	bin/nttcp
> +PLIST_FILES=	bin/nttcp man/man1/nttcp.1.gz

We usually try to move out PLIST_* knobs in separate block.  It makes even
more sense since ALL_TARGET, USES, MAKE_ENV, etc. are build-related stuff,
while PLIST_* are install/package-related ones.

>  USES=		gmake
>  MAKE_ENV+=	OPT="${CFLAGS}"
>  NOPRECIOUSMAKEVARS=yes
>  
> -NO_STAGE=	yes
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/
> -	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/
> +	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/
> +	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/

Manual pages should be installed relative to MAN[n]PREFIX, not PREFIX.
I also do not see the need for trailing slash, as these directories
are guaranteed to exist (they are part of the mtree).

./danfe


More information about the svn-ports-all mailing list