svn commit: r332567 - head/graphics/apvlv
Mark Felder
feld at FreeBSD.org
Mon Nov 4 14:26:15 UTC 2013
On Mon, Nov 4, 2013, at 8:20, Eitan Adler wrote:
> On Mon, Nov 4, 2013 at 9:15 AM, Mark Felder <feld at freebsd.org> wrote:
> >
> >
> > On Sun, Nov 3, 2013, at 13:38, Eitan Adler wrote:
> >> On Sun, Nov 3, 2013 at 2:14 PM, Tijl Coosemans <tijl at freebsd.org> wrote:
> >>
> >> > but now PTHREAD_CFLAGS is always empty
> >>
> >> Which is always a mistake. PTHREAD_CFLAGS should be replaced with
> >> -pthread
> >>
> >> so you can remove that line and PTHREAD_LIBS is always
> >> > -pthread.
> >>
> >> As should this.
> >>
> >
> > Thanks for the feedback guys. Perhaps we should put PTHREAD_CFLAGS and
> > PTHREAD_LIBS into portlint as well.
> >
> > I'm not 100% sure I understand the changes you're proposing -- I'm
> > getting caught up on the wording. Is this diff what you're suggesting?
>
> Yes.
>
Thank you. I will commit this change after doing a quick build test to
ensure nothing crazy happens.
More information about the svn-ports-all
mailing list