svn commit: r318913 - in head/devel/libcfu: . files

[Alexey Dokuchaev]

On Fri, May 24, 2013 at 07:14:09PM +0200, Eitan Adler wrote:
> On 24 May 2013 05:37, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > On Thu, May 23, 2013 at 10:05:22PM +0000, Chris Rees wrote:
> >> New Revision: 318913
> >> URL: http://svnweb.freebsd.org/changeset/ports/318913
> >>
> >> Log:
> >>   New versions of clang complain about assigning variables to themselves.
> >>
> >>   Let's just remove -Werror and ignore the warnings.
> >
> > Hmm, wouldn't it be better to fix these bugs (judging from commit log it
> > should not be too hard) and send the patch upstream?
> 
> I agree fixing these bugs is a good thing.  I don't believe that this
> is a function of the ports team though.  IMHO disabling warnings is
> the simplest, least intrusive patch that works.

Good maintainer typically would work with upstream to make sure their
software builds and runs on FreeBSD with little possible special tuning
required.  Not just it is "being nice", it also helps us to create and
maintain image of an OS that is worth writing software for. :)

While I agree that investing time in a large complex patch when simple
workaround is available is a bit too much (unless port maintainer is also
on the upstream devteam), fixing *simple* things such as compiler warnings
is better than throwing -Werror.

./danfe