svn commit: r323495 - head/games/f1lt

[Baptiste Daroussin]

On Tue, Jul 23, 2013 at 06:21:00PM +0200, John Marino wrote:
> On 7/23/2013 18:15, Bryan Drewery wrote:
> > Quite the contrary. If a change is needed it should be done now, not in
> > 2 months or years when it is convenient. Smaller logical commits are
> > much simpler to review and bisect than large commits. We should group
> > PORTVERSION/PORTREVISION changes together to prevent *rebuild churn*.
> 
> "If a change is needed"
> The issue is that it is debatable that this change is needed.
> It's redundant.
> It doesn't hurt anything.
> Personally I'm fine with this type of cleanup combined with *needed*
> change, but as a standalone commit, I agree with danfe that it doesn't
> add much.
> 
> Another example of this is trimming makefile headers without any
> additional change.
> 

I do agree with bryan here, because in 3 years, you will spend 10 hours finding
what the old unused MACRO was used for, trust me I have spent so much time
finding old cruft in the ports tree that I prefer to see the cruft go as soon as
possible than staying forever.

That said, I do prefer a couple of sweep commits let's say remove all
MAKE_JOBS_SAFE from the ports I do maintain in a single commit than doing it 1
by 1.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130723/274f4114/attachment.sig>