svn commit: r337439 - head/www/cntlm

[Alexey Dokuchaev]

On Wed, Dec 25, 2013 at 07:16:49PM +0000, Pawel Pekala wrote:
> New Revision: 337439
> URL: http://svnweb.freebsd.org/changeset/ports/337439
> 
> Log:
>   Fix build on -current
>   
>   [...]
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/cntlm ${STAGEDIR}${PREFIX}/bin/
> -	${INSTALL_DATA} ${WRKSRC}/doc/cntlm.conf ${STAGEDIR}${PREFIX}/etc/cntlm.conf.sample
> -	${INSTALL_MAN} ${WRKSRC}/doc/cntlm.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} cntlm \
> +		${STAGEDIR}${PREFIX}/bin)
> +	(cd ${WRKSRC}/doc && ${INSTALL_DATA} cntlm.conf.sample \
> +		${STAGEDIR}${PREFIX}/etc)
> +	(cd ${WRKSRC}/doc && ${INSTALL_MAN} cntlm.1 \
> +		${STAGEDIR}${MANPREFIX}/man/man1)

Pawel,

The last hunk has nothing to do with "fixing the build on current", it makes
the code harder to read (6 lines instead of three, line wrapping), and is a
gratuitous (and plain bad) change.

I appreciate Katobot's build fixing PR's and patches, but let's not take
them as perfect and use it in their entirety, esp. when they contradict our
normal practices and style.

./danfe