svn commit: r304300 - in head/java/jamvm: . files

[Baptiste Daroussin]

On Fri, Sep 14, 2012 at 10:02:10PM +0000, Jung-uk Kim wrote:
> Author: jkim
> Date: Fri Sep 14 22:02:09 2012
> New Revision: 304300
> URL: http://svn.freebsd.org/changeset/ports/304300
> 
> Log:
>   - Update to 1.5.4.
>   - Reset maintainer to java.
>   - Convert to optionsNG and add license.
>   - Unbreak sparc64.
>   
>   PR:	ports/164941 (partial)
> 
[...]
> +FFI_CFLAGS!=	pkgconf libffi --cflags
> +FFI_LDFLAGS!=	pkgconf libffi --libs-only-L

This is not a good idea as is because it break make index that way:
"Makefile", line 34: warning: "pkgconf libffi --cflags" returned non-zero status
"Makefile", line 35: warning: "pkgconf libffi --libs-only-L" returned non-zero status

if run on a system without pkgconf installed

to fix this part adding "|| :" at the end of the command might be a good idea.

I suspect (untested) that it may also make the ports fail to build in a
particular situation which is, on a system not having yet pkgconf you try to
install jamvm.

FFI_CFLAGS and FFI_LDFLAGS might in that case be expanded to nothing before
pkgconf is installed as a dependency.

The right fix should be then imho to patch the jamvm build system to invoke
pkgconf libffi itself.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20120916/f006c113/attachment.sig>