svn commit: r303734 - head/net-mgmt/pmacct/files

[Doug Barton]

Overall this rc.d script looks Ok. My one suggestion is that if -D is
the option to daemonize that it be moved to command_args instead of
relying on the user not to forget to include it if they override _flags.

Doug


On 9/5/2012 8:03 PM, Ryan Steinmetz wrote:
> Author: zi
> Date: Thu Sep  6 03:03:47 2012
> New Revision: 303734
> URL: http://svn.freebsd.org/changeset/ports/303734
> 
> Log:
>   - Fix issues in rc script + pkg-message
>   
>   Submitted by:	Karsten Schmidt <gugge at guggemand.dk>
> 
> Modified:
>   head/net-mgmt/pmacct/files/pkg-message.in
>   head/net-mgmt/pmacct/files/pmacctd.in
> 
> Modified: head/net-mgmt/pmacct/files/pkg-message.in
> ==============================================================================
> --- head/net-mgmt/pmacct/files/pkg-message.in	Thu Sep  6 02:30:30 2012	(r303733)
> +++ head/net-mgmt/pmacct/files/pkg-message.in	Thu Sep  6 03:03:47 2012	(r303734)
> @@ -3,7 +3,7 @@ Please note that this port requires conf
>  
>  Add these to /etc/rc.conf:
>  pmacctd_enable="YES"
> -pmacctd_flags="-DF %%PREFIX%%/etc/pmacctd.conf -i <interface>"
> +pmacctd_flags="-Df %%PREFIX%%/etc/pmacctd.conf -i <interface>"
>  
>  Configuration examples are located in %%EXAMPLESDIR%%.  You must copy
>  one of these to %%PREFIX%%/etc/pmacctd.conf and make any required edits
> 
> Modified: head/net-mgmt/pmacct/files/pmacctd.in
> ==============================================================================
> --- head/net-mgmt/pmacct/files/pmacctd.in	Thu Sep  6 02:30:30 2012	(r303733)
> +++ head/net-mgmt/pmacct/files/pmacctd.in	Thu Sep  6 03:03:47 2012	(r303734)
> @@ -25,7 +25,7 @@
>  name=pmacctd
>  rcvar=pmacctd_enable
>  
> -command=%%PREFIX%%/$name
> +command=%%PREFIX%%/sbin/$name
>  
>  # set defaults
>  
> 


-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)