svn commit: r305403 - head/graphics/eos-movrec
Alex Kozlov
spam at rm-rf.kiev.ua
Sun Oct 7 09:45:26 UTC 2012
On Sun, Oct 07, 2012 at 12:37:24PM +0400, Boris Samorodov wrote:
> Hello Alex,
>
> > Log:
> > - Convert Makefile headers to new style
> > - Add DESKTOP_ENTRIES
> > - Pass maintainership to nemysis <nemysis at gmx.ch>
> As for me this is too simplified commit log. May be added:
>
> - Use bzip2 instead of zip tarball (greatly reduses the size)
> - Remove duplicate PORTREVISION
> - Remove the indefinite article from COMMENT
> - Remove shlib version from the dependency
> - convert and install icon *.png from *.ico
Apologies, I forgot to update message file.
Convert and install icon included in add DESKTOP_ENTRIES though,
desktop entry need to have an icon.
> And those changes are definitely demand a PORTREVISION bump.
> There are some notes inline.
>
> > PR: ports/172342
> Since you committed a different patch it's better to point this out.
The patch was substantially improved after discussion on irc, but it's
still (technically) submitted by pr author.
I guess I could have used something like: PR: ports/172342 (based on)
> > Submitted by: nemysis <nemysis at gmx.ch>
> >
> > Modified:
> > head/graphics/eos-movrec/Makefile (contents, props changed)
> > head/graphics/eos-movrec/distinfo (contents, props changed)
> >
> > Modified: head/graphics/eos-movrec/Makefile
> > ==============================================================================
> > --- head/graphics/eos-movrec/Makefile Sat Oct 6 20:50:12 2012 (r305402)
> > +++ head/graphics/eos-movrec/Makefile Sat Oct 6 21:05:12 2012 (r305403)
> > @@ -1,34 +1,42 @@
> > -# New ports collection makefile for: EOS camera movie record
> > -# Date created: 15 Aug 2011
> > -# Whom: Alexey Dokuchaev <danfe at FreeBSD.org>
> > -#
> > # $FreeBSD$
> > -#
> > +# Created by: Alexey Dokuchaev <danfe at FreeBSD.org>
> Imho this line should be the first one.
At the moment there are three or four variants of Makefile headers in the tree.
I try to be as close as possible to the official version:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-samplem.html
> > PORTNAME= eos-movrec
> > DISTVERSION= 0.3.1_beta
> > PORTREVISION= 1
> > CATEGORIES= graphics
> I'm not sure, but may be this port belongs to multimedia?
Hm. I'm not sure either, will ask maintainer.
> > -MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/0.3_beta
> > +MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/0.3_beta/
> >
> > -MAINTAINER= ports at FreeBSD.org
> > -COMMENT= A program to capture short movies with Canon DSLR camera
> > +MAINTAINER= nemysis at gmx.ch
> > +COMMENT= Program to capture short movies with Canon DSLR camera
> May be this is a matter of taste but I'll say that "Program to" may be
> trimmed too.
> > LICENSE= GPLv2
> >
> > -LIB_DEPENDS= gphoto2.2:${PORTSDIR}/graphics/libgphoto2
> > +LIB_DEPENDS= gphoto2:${PORTSDIR}/graphics/libgphoto2
> > +BUILD_DEPENDS= pnmtopng:${PORTSDIR}/graphics/netpbm
> >
> > -USE_ZIP= yes
> > +USE_BZIP2= yes
> > USE_CMAKE= yes
> > +CMAKE_VERBOSE= yes
> Seems to be a diagnistic only tool. Is it necessary for every build?
I don't see any harm in it. But I will ask the maintainer if he agrees to
remove it.
> > +post-build:
> > + @(cd ${WRKSRC} && ${LOCALBASE}/bin/winicontoppm -bestqual eos-movrec2.ico | \
> > + ${LOCALBASE}/bin/pnmtopng > eos-movrec.png)
>
> This is an interesting trick. Is it documented anywhere?
No. You need to read netpbm documentation online.
--
Alex
More information about the svn-ports-all
mailing list