svn commit: r305338 - in head/games/pycadia: . files

[Jason Helfman]

On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton <dougb at freebsd.org> wrote:

> On 10/05/2012 22:37, Jason Helfman wrote:
> > Added: head/games/pycadia/files/pycadia.sh.in
> >
> ==============================================================================
> > --- /dev/null 00:00:00 1970   (empty, because file is newly added)
> > +++ head/games/pycadia/files/pycadia.sh.in    Sat Oct  6 05:37:29 2012
>        (r305338)
> > @@ -0,0 +1,6 @@
> > +#!/bin/sh
> > +#
> > +# $FreeBSD$
> > +
> > +cd "%%DATADIR%%"
> > +./pycadia.py
>
> Unless there is some reason to cd into that directory, you'd be better
> off with just: %%DATADIR%%/pycadia.py
>
> And in any case, shouldn't you be using exec here?
>

I can check with the maintainer, but it does need to be run from the
DATADIR specifically.
What would exec provide that isn't currently fulfilled?

Thanks

-jgh