svn commit: r307902 - head/graphics/grafx2/files

Eitan Adler eadler at freebsd.org
Fri Nov 30 02:53:02 UTC 2012


On 29 November 2012 07:32, Emanuel Haupt <ehaupt at freebsd.org> wrote:
> Eitan Adler <eadler at FreeBSD.org> wrote:
>> On 28 November 2012 15:35, Emanuel Haupt <ehaupt at freebsd.org> wrote:
>> > Eitan Adler <eadler at freebsd.org> wrote:
>> >> On 28 November 2012 06:29, Emanuel Haupt <ehaupt at freebsd.org>
>> >> wrote:
>> >> > Author: ehaupt
>> >> > Date: Wed Nov 28 11:29:06 2012
>> >> > New Revision: 307902
>> >> > URL: http://svnweb.freebsd.org/changeset/ports/307902
>> >> >
>> >> > Log:
>> >> >   Add patchfile.
>> >>
>> >> What does the patchfile do? Why is it needed? Was upstream
>> >> contacted?
>> >>
>> >> - these should be documented in the log message.
>> >
>> > It is part of the update 2 minutes earlier. I thought this was
>> > obvious.
>>
>> Ah, I didn't see this.   In any case it would help to document these
>> things - especially the part about whether upstream ACKed/NACKed the
>> patch.
>
> You're right, I should have mentioned that in my follow up commit. The
> patch has been submitted upstream. Haven't heard back so far.

Thanks.  My mail may have seemed unnecessarily strong. I just try to
mention these things so people don't forget the next time.

~ Eitan - king of making mistakes :)


More information about the svn-ports-all mailing list