svn commit: r307782 - head/audio/asunder

[Guido Falsi]

On 11/26/12 17:57, Eitan Adler wrote:
> On 26 November 2012 11:11, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> On Mon, Nov 26, 2012 at 04:57:23PM +0100, Guido Falsi wrote:
>>> On 11/26/12 14:56, Alexey Dokuchaev wrote:
>>>> We have standard knob for this one (APE_DESC).
>>>>
>>>>>   PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO
>>>>
>>>> Normally we do not install COPYING as part of the docs, LICENSE should be
>>>> set instead.  If software expects to find this file (e.g. for displaying in
>>>> the about dialog), it should be redirected to share/licenses/${PKGNAME}
>>>> instead (see `graphics/luminance' port for an example).
>>>
>>> Thanks for these, I'll fix them and commit after maintainer approval.
>>
>> Technically speaking, you don't have to have maintainer's approval for these
>> things, as they don't affect functionality, just make the port more adhering
>> to our standards (and common sense).
>
> It is good to ping the maintainer though unless there is specific reason not to.
> - Since they signed up to maintain the port its nice not to change
> things without asking
> - It teaches the maintainers about our standards :)

I agree.

I'd rather ping them if the problem is not really urgent(i.e. broken 
index, broken dependencies etc.) or really really trivial (i.e. typo, 
fixing a comment/header).

Anyway if I don't get an answer in a decent time I'll go ahead and fix 
this anyway.

-- 
Guido Falsi <madpilot at FreeBSD.org>