svn commit: r307457 - head/Mk

[Eitan Adler]

On 15 November 2012 11:38, Baptiste Daroussin <bapt at freebsd.org> wrote:
> On Thu, Nov 15, 2012 at 11:22:47AM -0500, Eitan Adler wrote:
>> On 15 November 2012 11:12, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> > On Thu, Nov 15, 2012 at 10:08:06AM -0500, Eitan Adler wrote:
>> >> On 15 November 2012 09:36, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> >> > New Revision: 307457
>> >> > URL: http://svnweb.freebsd.org/changeset/ports/307457
>> >> >
>> >> > Log:
>> >> >   Add SOCKS and STROKE options standard descriptions.
>> >>
>> >> Can portmgr please make it more clear what is and isn't permitted
>> >> during a feature freeze?
>> >> http://www.freebsd.org/portmgr/implementation.html would seem to say
>> >> that this commit is not allowed (any commit to bsd.*.mk) but I've seen
>> >> already a few commits to this file.
>> >
>> > Oops, technically you're right, sorry, didn't catch that *any* part.  On
>> > the other hand, I do not think this particular commit can break anything,
>> > plus we already had branched.  I can grep -R just to make sure.
>>
>> To be clear:
>>
>> I want portmgr to clarify this. I *don't* want this to be disallowed.
>>
>> The problem is that there isn't any document that is actually being followed
>> that says "this is okay, but that isn't".
>>
>>
>>
>>
>> --
>> Eitan Adler
>> Source, Ports, Doc committer
>> Bugmeister, Ports Security teams
>
> Everything can't be written in a policy, or that would be so long that noone
> will actually read it.
>
> We expect people to have some common sense. The main reason for this freeze is
> to be able to have clean packages for the release and we don't want any commit
> to break the tree so that we are sure to have the cleanest packages tree possible.
>
> So before committing ask yourself "does it ever has a chance to be able to break
> things?"

...

I agree. Can that page please be modified then to make this more clear?


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams