svn commit: r307446 - head/www/xpi-colorfultabs

Philippe Audéoud jadawin at FreeBSD.org
Thu Nov 15 10:46:42 UTC 2012


On Thu, 15 Nov 2012, Alexey Dokuchaev wrote:

> On Thu, Nov 15, 2012 at 11:26:11AM +0100, Florian Smeets wrote:
> > On 11/15/2012 11:22, Emanuel Haupt wrote:
> > > These two files are probably not needed.
> > 
> > Yeah, i know. I saw them but decided to just add them to the plist,
> > rather than hacking up the Makefile with something to use find on the
> > WRKSRC and delete them.
> > 
> > If anybody sees this as a problem, i can hack the Makefile to delete
> > them prior to installation.
> 
> Yes, it is a problem.  It makes us (FreeBSD) look like careless fools not
> even able (or giving a shit about) to keep crap out of the packages we ship.
> These things add up, regardless of how non-functional they might be, to the
> bad impression of us.  Please try to make ports nice and clean, remove the
> crap, it's very easy:
> 
> post-extract:
> # Remove the crap
> 	@${FIND} ${WRKSRC} -type f -name ... -delete
> 
> Slighly longer for directories.
> 
> ./danfe

Agreed with danfe and you should drop a mail to upstream maintainer to
warn him about theses useless files!

-- 
Philippe Audéoud


More information about the svn-ports-all mailing list