Remove unnecessary change to Mk/bsd.port.mk (: svn commit: r303619 - head/Mk)

Olli Hauer ohauer at FreeBSD.org
Mon Nov 5 05:48:57 UTC 2012


On 2012-11-04 15:09, Gerald Pfeifer wrote:
> I understand Mk/bsd.port.mk is not applicable for maintainer 
> timeouts or I would have gone ahead and committed the patch
> below.
> 
> Can you please have a look?
> 
> Thanks,
> Gerald
> 
> On Wed, 5 Sep 2012, Gerald Pfeifer wrote:
>>> +CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>>> +.endif
>>
>> Really?
>>
>> Something looks fundamentally wrong if you have to do this under
>> .if defined(USE_READLINE), at least past
>>
>>   r270411 | erwin | 2011-03-07 07:32:05 +0000 (Mon, 07 Mar 2011) | 5 lines
>>
>>   Pass CPPFLAGS to MAKE_ENV and CONFIGURE_ENV
>>
>>   PR:             153625
>>   Submitted by:   gerald
>>
>> How about the patch below?
>>
>> Gerald
>>
>> Index: bsd.port.mk
>> ===================================================================
>> --- bsd.port.mk	(revision 303674)
>> +++ bsd.port.mk	(working copy)
>> @@ -1708,7 +1708,6 @@
>>  LIB_DEPENDS+=	readline.6:${PORTSDIR}/devel/readline
>>  CPPFLAGS+=		-I${LOCALBASE}/include
>>  LDFLAGS+=		-L${LOCALBASE}/lib -lreadline
>> -CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
>>  .endif
>>  .endif
>>  
> 

Maybe fjoe@ can explain why CONFIGURE_ENV was placed here.
The line was part of PR 162995.




More information about the svn-ports-all mailing list