svn commit: r308491 - in head: . textproc textproc/elasticsearch textproc/elasticsearch/files

[Alexey Dokuchaev]

On Sat, Dec 08, 2012 at 08:48:41PM +0000, Tom Judge wrote:
> New Revision: 308491
> URL: http://svnweb.freebsd.org/changeset/ports/308491
> 
> Log:
>   Elasticsearch aims to be a Distributed, RESTful, Search Engine built on
>   top of Apache Lucene.
> +# Created by:	Tom Judge <tj at FreeBSD.org>

Wrong header format (should have used space, not a tab here).  Was fixed in
r308605 by bapt at .

> +MAINTAINER=	tj at FreeBSD.org
> +COMMENT=	A full-text search engine for Java

COMMENT should not begin with an article.

> +JAVA_VERSION=	1.5+

I thought 1.5 would be deprecated soon.  Again, fixed in r308605.

> +DOCS=		LICENSE.txt \

Any reason to install LICENSE.txt file for a standard license?

> +post-patch:
> +	${SED} -i .bak -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/config/elasticsearch.yml

What's wrong with REINPLACE_CMD?  Is there necessity for global modifier in
regexp?

> +	${MKDIR} ${PREFIX}/lib/elasticsearch
> ...
> +	${MKDIR} ${PREFIX}/lib/elasticsearch/sigar

Usually MKDIR's are muted...  Also, first statement is not required as MKDIR
implies -p.

> +	@${MKDIR} ${DOCSDIR}

... Like you do here. ;-)

./danfe