svn commit: r308484 - head/textproc/idnits

Pietro Cerutti gahr at FreeBSD.org
Mon Dec 10 09:09:29 UTC 2012


On 2012-Dec-10, 08:48, Alexey Dokuchaev wrote:
> On Sat, Dec 08, 2012 at 04:26:32PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> > New Revision: 308484
> > URL: http://svnweb.freebsd.org/changeset/ports/308484
> > 
> >  post-patch:
> > -	@${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' \
> > -		${WRKSRC}/${PORTNAME}
> > +	@${REINPLACE_CMD} -e '1 s|^#!/bin/bash|#!${LOCALBASE}/bin/bash|' ${WRKSRC}/${PORTNAME}
> 
> Do you mind backing this hunk out?  Previous version was much better (most of
> us still use standard 80-char wide xterms).

What about we *first* document somewhere that line width must be <= 80
(or 76, fwiw) and *then* try to enforce it on others' commits?

Not that I'm against it in principle, but I don't feel comfortable with
you making law out of your personal preference.


-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20121210/78fa43d7/attachment.sig>


More information about the svn-ports-all mailing list