svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js

[Eitan Adler]

On 8 June 2013 00:47, Hiroki Sato <hrs at freebsd.org> wrote:
> Eitan Adler <eadler at freebsd.org> wrote
>   in <CAF6rxgnxjDn_sjviCSZVpMDs40OYZS6D6MrKzs0YZvm2sC-qdg at mail.gmail.com>:
>
> ea> On 7 June 2013 17:34, Tom Rhodes <trhodes at freebsd.org> wrote:
> ea> > On Fri, 07 Jun 2013 09:25:34 +0900 (JST)
> ea> > Hiroki Sato <hrs at FreeBSD.org> wrote:
> ea> >
> ea> >> Eitan Adler <eadler at freebsd.org> wrote
> ea> >>   in <CAF6rxg=tnyCyLP50RpO8j20jbnGO_Mycb7aq5P3pRVz9NtvokA at mail.gmail.com>:
> ea> >>
> ea> >> ea> On 6 June 2013 16:28, Hiroki Sato <hrs at freebsd.org> wrote:
> ea> >> ea> >
> ea> >> ea> >  null, "", and undefined are evaluated as false in Javascript.
> ea> >> ea> >
> ea> >> ea> Javascript has an odd concept of true and false:
> ea> >> ea> null, an empty string,  +0, -0, and NaN, and false are the 'false' values.
> ea> >> ea>
> ea> >> ea> An object will return true.
> ea> >>
> ea> >>  I see.  I am not familiar with DNT implementation, but is there a www
> ea> >>  browser to define navigator.doNotTrack as the value "false"?
> ea> >>
> ea> >>  If so, I think something like the following is needed.
> ea> >>
> ea> >>  var dnt = window.navigator.msDoNotTrack || window.navigator.doNotTrack;
> ea> >>  var allow_track = (dnt && dnt == 'yes'|| dnt == 1);
> ea> >>
> ea> >> -- Hiroki
> ea> >>
> ea> >
> ea> > I was assuming based on the discussion that we need to perform
> ea> > more than a single check on this, but will this one actually
> ea> > work?
> ea>
> ea> No, after some thoughts I realized that this commit is completely
> ea> broken.  We must explicitly check for "yes" and "1". This check
> ea> basically disabled GA for newer browsers.
>
>  The above code should perform it.

Sorry, I was unclear: the version as you explained (checking for
existence followed by and explicit "1" or "yes") should be fine.

>   What is "this check" in your
>  sentence?

The version as committed.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams