svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js
hrs at FreeBSD.org
Fri Jun 7 23:04:31 UTC 2013
Eitan Adler <eadler at freebsd.org> wrote
in <CAF6rxgmSZcfVR1kCGs5RaihxdsQXbqxhbuUo4XRUPrGE_FGcww at mail.gmail.com>:
ea> On 8 June 2013 00:47, Hiroki Sato <hrs at freebsd.org> wrote:
ea> > ea> >> var dnt = window.navigator.msDoNotTrack || window.navigator.doNotTrack;
ea> > ea> >> var allow_track = (dnt && dnt == 'yes'|| dnt == 1);
ea> > ea> >>
ea> > ea> >> -- Hiroki
ea> > ea> >>
ea> > ea> >
ea> > ea> > I was assuming based on the discussion that we need to perform
ea> > ea> > more than a single check on this, but will this one actually
ea> > ea> > work?
ea> > ea>
ea> > ea> No, after some thoughts I realized that this commit is completely
ea> > ea> broken. We must explicitly check for "yes" and "1". This check
ea> > ea> basically disabled GA for newer browsers.
ea> > The above code should perform it.
ea> Sorry, I was unclear: the version as you explained (checking for
ea> existence followed by and explicit "1" or "yes") should be fine.
ea> > What is "this check" in your
ea> > sentence?
ea> The version as committed.
Okay, thanks. I agree that differences between DNT specification and
actual implementations are annoying...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 196 bytes
Desc: not available
More information about the svn-doc-all