svn commit: r41848 - head/en_US.ISO8859-1/htdocs/layout/js

Hiroki Sato hrs at
Fri Jun 7 22:48:14 UTC 2013

Eitan Adler <eadler at> wrote
  in <CAF6rxgnxjDn_sjviCSZVpMDs40OYZS6D6MrKzs0YZvm2sC-qdg at>:

ea> On 7 June 2013 17:34, Tom Rhodes <trhodes at> wrote:
ea> > On Fri, 07 Jun 2013 09:25:34 +0900 (JST)
ea> > Hiroki Sato <hrs at> wrote:
ea> >
ea> >> Eitan Adler <eadler at> wrote
ea> >>   in <CAF6rxg=tnyCyLP50RpO8j20jbnGO_Mycb7aq5P3pRVz9NtvokA at>:
ea> >>
ea> >> ea> On 6 June 2013 16:28, Hiroki Sato <hrs at> wrote:
ea> >> ea> >
ea> >> ea> >  null, "", and undefined are evaluated as false in Javascript.
ea> >> ea> >
ea> >> ea> Javascript has an odd concept of true and false:
ea> >> ea> null, an empty string,  +0, -0, and NaN, and false are the 'false' values.
ea> >> ea>
ea> >> ea> An object will return true.
ea> >>
ea> >>  I see.  I am not familiar with DNT implementation, but is there a www
ea> >>  browser to define navigator.doNotTrack as the value "false"?
ea> >>
ea> >>  If so, I think something like the following is needed.
ea> >>
ea> >>  var dnt = window.navigator.msDoNotTrack || window.navigator.doNotTrack;
ea> >>  var allow_track = (dnt && dnt == 'yes'|| dnt == 1);
ea> >>
ea> >> -- Hiroki
ea> >>
ea> >
ea> > I was assuming based on the discussion that we need to perform
ea> > more than a single check on this, but will this one actually
ea> > work?
ea> No, after some thoughts I realized that this commit is completely
ea> broken.  We must explicitly check for "yes" and "1". This check
ea> basically disabled GA for newer browsers.

 The above code should perform it.  What is "this check" in your

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <>

More information about the svn-doc-all mailing list