PERFORCE change 182874 for review

Hans Petter Selasky hselasky at FreeBSD.org
Wed Aug 25 07:22:00 UTC 2010


http://p4web.freebsd.org/@@182874?ac=10

Change 182874 by hselasky at hselasky_laptop001 on 2010/08/25 07:21:44

	USB controller (EHCI):
		- use same check like in XHCI driver for
		setting the CERR field.
		- we should not use this feature during
		normal data transactions, but rather let
		the data transfers fail if there is bad
		signal conditions so.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#59 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#59 (text+ko) ====

@@ -1866,7 +1866,8 @@
 		temp.auto_data_toggle = 1;
 	}
 
-	if (usbd_get_speed(xfer->xroot->udev) != USB_SPEED_HIGH) {
+	if ((xfer->xroot->udev->parent_hs_hub != NULL) ||
+	    (xfer->xroot->udev->address != 0)) {
 		/* max 3 retries */
 		temp.qtd_status |=
 		    htohc32(temp.sc, EHCI_QTD_SET_CERR(3));


More information about the p4-projects mailing list