PERFORCE change 168764 for review

Alexander Motin mav at FreeBSD.org
Tue Sep 22 11:04:27 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=168764

Change 168764 by mav at mav_mavbook on 2009/09/22 11:04:11

	Fix old PIO PCCARD devices. 

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/cam/ata/ata_xpt.c#36 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/cam/ata/ata_xpt.c#36 (text+ko) ====

@@ -668,6 +668,9 @@
 
 			path->device->flags |= CAM_DEV_IDENTIFY_DATA_VALID;
 			ata_device_transport(path);
+			/* Old PIO devices do not need mode setting. */
+			if ((ident_buf->capabilities1 & ATA_SUPPORT_IORDY) == 0)
+				goto modedone;
 			PROBE_SET_ACTION(softc, PROBE_SETMODE);
 			xpt_release_ccb(done_ccb);
 			xpt_schedule(periph, priority);
@@ -700,7 +703,7 @@
 	case PROBE_SETMODE:
 	{
 		if ((done_ccb->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP) {
-			if (path->device->protocol == PROTO_ATA) {
+modedone:		if (path->device->protocol == PROTO_ATA) {
 				path->device->flags &= ~CAM_DEV_UNCONFIGURED;
 				done_ccb->ccb_h.func_code = XPT_GDEV_TYPE;
 				xpt_action(done_ccb);


More information about the p4-projects mailing list