PERFORCE change 166865 for review

Hans Petter Selasky hselasky at FreeBSD.org
Fri Jul 31 19:39:07 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=166865

Change 166865 by hselasky at hselasky_laptop001 on 2009/07/31 19:39:04

	
	USB Ethernet:
	
	We used force all of the GPIO pins low first and then
	enable the ones we want. This has been changed to better
	match the ADMtek's reference design to avoid setting the
	power-down configuration line of the PHY at the same time
	it is reset.
	
	Patch by: John Hood

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/net/if_aue.c#15 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/net/if_aue.c#15 (text+ko) ====

@@ -484,7 +484,7 @@
 	}
 
 	if (i == AUE_TIMEOUT)
-		device_printf(sc->sc_ue.ue_dev, "MII read timed out\n");
+		device_printf(sc->sc_ue.ue_dev, "MII write timed out\n");
 
 	if (!locked)
 		AUE_UNLOCK(sc);
@@ -603,11 +603,14 @@
 	 * to set the GPIO pins high so that the PHY(s) will
 	 * be enabled.
 	 *
-	 * Note: We force all of the GPIO pins low first, *then*
-	 * enable the ones we want.
+	 * NOTE: We used force all of the GPIO pins low first and then
+	 * enable the ones we want. This has been changed to better
+	 * match the ADMtek's reference design to avoid setting the
+	 * power-down configuration line of the PHY at the same time
+	 * it is reset.
 	 */
-	aue_csr_write_1(sc, AUE_GPIO0, AUE_GPIO_OUT0|AUE_GPIO_SEL0);
-	aue_csr_write_1(sc, AUE_GPIO0, AUE_GPIO_OUT0|AUE_GPIO_SEL0|AUE_GPIO_SEL1);
+	aue_csr_write_1(sc, AUE_GPIO0, AUE_GPIO_SEL0|AUE_GPIO_SEL1);
+	aue_csr_write_1(sc, AUE_GPIO0, AUE_GPIO_SEL0|AUE_GPIO_SEL1|AUE_GPIO_OUT0);
 
 	if (sc->sc_flags & AUE_FLAG_LSYS) {
 		/* Grrr. LinkSys has to be different from everyone else. */


More information about the p4-projects mailing list