PERFORCE change 161116 for review

Marko Zec zec at FreeBSD.org
Sun Apr 26 17:36:35 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=161116

Change 161116 by zec at zec_amdx2 on 2009/04/26 17:36:10

	Access from userland to igmpstat is provided via a sysctl
	(which is already V_irtualized).  Hence, there's no need
	for kmem / kldsym kludges, so vnet_igmp_symmap can go away.
	If not, it should be added to vnet_inet_symmap, because
	struct vnet_igmp doesn't exist anyway.
	
	XXX why was igi_head ever put in vnet_iugmp_symmap?

Affected files ...

.. //depot/projects/vimage-commit/src/sys/netinet/igmp.c#15 edit

Differences ...

==== //depot/projects/vimage-commit/src/sys/netinet/igmp.c#15 (text+ko) ====

@@ -3620,19 +3620,6 @@
 	return (0);
 }
 
-/*
- * XXX Are igi_head and igmpstat really accessed via kmem / kldsym?
- * If so, given that they are members of struct vnet_inet, they should
- * be registered with VNET_MOD_INET, not here.  Revisit!!!
- */
-#if 0
-static struct vnet_symmap vnet_igmp_symmap[] = {
-	VNET_SYMMAP(igmp, igi_head),
-	VNET_SYMMAP(igmp, igmpstat),
-	VNET_SYMMAP_END
-};
-#endif
-
 #ifndef VIMAGE_GLOBALS
 static vnet_modinfo_t vnet_igmp_modinfo = {
 	.vmi_id		= VNET_MOD_IGMP,


More information about the p4-projects mailing list