PERFORCE change 151526 for review

Sam Leffler sam at FreeBSD.org
Sat Oct 18 23:20:03 UTC 2008


http://perforce.freebsd.org/chv.cgi?CH=151526

Change 151526 by sam at sam_ebb on 2008/10/18 23:19:07

	update the tx rssi only when the frame was ACK'd

Affected files ...

.. //depot/projects/vap/sys/dev/ath/if_ath.c#98 edit

Differences ...

==== //depot/projects/vap/sys/dev/ath/if_ath.c#98 (text+ko) ====

@@ -5048,9 +5048,6 @@
 				sc->sc_ant_tx[txant]++;
 				if (ts->ts_rate & HAL_TXSTAT_ALTRATE)
 					sc->sc_stats.ast_tx_altrate++;
-				sc->sc_stats.ast_tx_rssi = ts->ts_rssi;
-				ATH_RSSI_LPF(sc->sc_halstats.ns_avgtxrssi,
-					ts->ts_rssi);
 				pri = M_WME_GETAC(bf->bf_m);
 				if (pri >= WME_AC_VO)
 					ic->ic_wme.wme_hipri_traffic++;
@@ -5076,11 +5073,16 @@
 			if ((ts->ts_status & HAL_TXERR_FILT) == 0 &&
 			    (bf->bf_flags & HAL_TXDESC_NOACK) == 0) {
 				/*
-				 * If frame was ack'd update the last rx time
-				 * used to workaround phantom bmiss interrupts.
+				 * If frame was ack'd update statistics,
+				 * including the last rx time used to
+				 * workaround phantom bmiss interrupts.
 				 */
-				if (ts->ts_status == 0)
+				if (ts->ts_status == 0) {
 					nacked++;
+					sc->sc_stats.ast_tx_rssi = ts->ts_rssi;
+					ATH_RSSI_LPF(sc->sc_halstats.ns_avgtxrssi,
+						ts->ts_rssi);
+				}
 				ath_rate_tx_complete(sc, an, bf);
 			}
 			/*


More information about the p4-projects mailing list