PERFORCE change 135010 for review

Ruslan Ermilov ru at FreeBSD.org
Sun Mar 2 07:31:47 UTC 2008


Hi John,

Your patch below looks good enough for committing.

On Fri, Feb 15, 2008 at 09:52:38AM -0500, John Baldwin wrote:
> Index: kmod.mk
> ===================================================================
> RCS file: /usr/cvs/src/sys/conf/kmod.mk,v
> retrieving revision 1.221
> diff -u -r1.221 kmod.mk
> --- kmod.mk	19 Nov 2007 16:24:10 -0000	1.221
> +++ kmod.mk	15 Feb 2008 14:50:03 -0000
> @@ -428,6 +428,9 @@
>  assym.s: @/kern/genassym.sh
>  .endif
>  	sh @/kern/genassym.sh genassym.o > ${.TARGET}
> +.if defined(KERNBUILDDIR)
> +genassym.o: opt_global.h
> +.endif
>  .if exists(@)
>  genassym.o: @/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c
>  .endif
> @@ -439,6 +442,10 @@
>  lint: ${SRCS}
>  	${LINT} ${LINTKERNFLAGS} ${CFLAGS:M-[DILU]*} ${.ALLSRC:M*.c}
>  
> +.if defined(KERNBUILDDIR)
> +${OBJS}: opt_global.h
> +.endif
> +
>  .include <bsd.dep.mk>
>  
>  cleandepend: cleanilinks
> 
> 
> BTW, reading kmod.mk the submit above only works if .depend doesn't exist.  It 
> won't work if you have run 'make depend' because of this:
> 
> .if !exists(${.OBJDIR}/${DEPENDFILE})
> ${OBJS}: ${SRCS:M*.h}
> .endif


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer


More information about the p4-projects mailing list