PERFORCE change 145018 for review

[Anselm Strauss]

http://perforce.freebsd.org/chv.cgi?CH=145018

Change 145018 by strauss at strauss_marvelman on 2008/07/10 13:47:51

	- sizeof/strlen fix
	- Enabled all compiler warnings globally

Affected files ...

.. //depot/projects/soc2008/strauss_libarchive/Makefile.am#6 edit
.. //depot/projects/soc2008/strauss_libarchive/TODO#9 edit
.. //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#8 edit

Differences ...

==== //depot/projects/soc2008/strauss_libarchive/Makefile.am#6 (text+ko) ====

@@ -429,3 +429,5 @@
 	cpio/test/test_option_t.cpio.uu		\
 	cpio/test/test_option_t.stdout.uu	\
 	cpio/test/test_option_tv.stdout.uu
+
+AM_CFLAGS="-Wall"

==== //depot/projects/soc2008/strauss_libarchive/TODO#9 (text+ko) ====

@@ -1,7 +1,6 @@
 To Be Done
 ==========
 
-- How to enable '-Wall' in gcc when calling make?
 - Exception handling in ZIP writer
 - Update ZIP writer in docs
 - Integrate Libarchive 2.5.5
@@ -12,6 +11,7 @@
 Already Done
 ============
 
+- How to enable '-Wall' in gcc when calling make? -> Use 'make CFLAGS="-Wall" ...'
 - Update ZIP writer in headers
 - Build does not work outside source dir
 - Enable P4 keyword expansion and adapt all source files

==== //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#8 (text+ko) ====

@@ -165,7 +165,7 @@
 	/* Write filename and extra field (extra field is currently null).
 	 * These are not included in the header structure due to variable size. */
 	const char *path = archive_entry_pathname(entry);
-	ret = (a->compressor.write)(a, path, sizeof(*path));
+	ret = (a->compressor.write)(a, path, strlen(path));
 	if (ret != ARCHIVE_OK)
 		return (ARCHIVE_FATAL);