PERFORCE change 144729 for review

Takahashi Yoshihiro nyan at jp.FreeBSD.org
Sun Jul 6 01:42:32 UTC 2008


In article <200807051805.m65I5T4Y056554 at repoman.freebsd.org>
Marcel Moolenaar <marcel at freebsd.org> writes:

> @@ -67,9 +65,7 @@
>  	struct uart_class *class;
>  	unsigned int i, j, ivar;
>  
> -	class = &uart_ns8250_class;	/* currently ns8250 only */
> -	if (class == NULL)
> -		return (ENXIO);
> +	class = &uart_i8251_class;
>  
>  	/* Check the environment. */
>  	if (uart_getenv(devtype, di, class) == 0)

Please revert this change.  We want to use ns8250 class as default.
And the above comment in the diff was wrong...
The uart_i8251_class should be added to the uart_classes in uart_subr.c.

---
TAKAHASHI Yoshihiro <nyan at jp.FreeBSD.org>


More information about the p4-projects mailing list