PERFORCE change 132497 for review

[Brooks Davis]

On Fri, Jan 04, 2008 at 11:19:26AM -0700, M. Warner Losh wrote:
> In message: <200801041711.m04HBGPG029002 at repoman.freebsd.org>
>             Oleksandr Tymoshenko <gonzo at freebsd.org> writes:
> : http://perforce.freebsd.org/chv.cgi?CH=132497
> : 
> : Change 132497 by gonzo at gonzo_jeeves on 2008/01/04 17:11:07
> : 
> : 	o I believe MK_ZFS is more appropriate variable to be checked
> : 	    in this case.
> 
> I thought this was more a case of 'exclude all CDDL code' rather than
> being tied to ZFS.

${MK_CDDL} == "no" absolutely needs to cause ZFS bits to not build.  I'm
not sure if ${MK_CDDL} == "no" implies ${MK_ZFS} != "no".  If so this is
OK, if not it isn't.

-- Brooks

> Warner
> 
> : Affected files ...
> : 
> : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit
> : 
> : Differences ...
> : 
> : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko) ====
> : 
> : @@ -13,7 +13,7 @@
> :  
> :  CFLAGS+=-D_KVM_VNODE
> :  
> : -.if ${MK_CDDL} != "no"
> : +.if ${MK_ZFS} != "no"
> :  CFLAGS+= -DZFS
> :  OBJS+= zfs/zfs.o
> :  SUBDIR=	zfs
> : 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/p4-projects/attachments/20080104/119bfb3b/attachment.pgp