PERFORCE change 126330 for review

Kip Macy kip.macy at gmail.com
Wed Sep 12 15:18:31 PDT 2007


On 9/12/07, Pawel Jakub Dawidek <pjd at freebsd.org> wrote:
> On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=126330
> >
> > Change 126330 by kmacy at kmacy_home:ethng on 2007/09/12 08:31:36
> >
> >       convert radix node head and route locks from mutexes to rwlocks
> [...]
> >               rt->rt_flags |= RTF_LLINFO;
> > -             callout_init_mtx(&la->la_timer, &rt->rt_mtx,
> > -                 CALLOUT_RETURNUNLOCKED);
> > +             callout_init_rwlock(&la->la_timer, &rt->rt_lock,
> > +                 CALLOUT_RETURNUNLOCKED_RW);
> >
>
> Kip, don't add callout_init_rwlock() to the tree. I've
> callout_init_lock() implemented that operates on any lock type, just
> like condvar(9).

point me to a diff


More information about the p4-projects mailing list