PERFORCE change 127983 for review

Christian S.J. Peron csjp at FreeBSD.org
Tue Oct 23 17:11:05 PDT 2007


http://perforce.freebsd.org/chv.cgi?CH=127983

Change 127983 by csjp at push on 2007/10/24 00:10:51

	Move where we audit the PID argument such that we unconditionally
	audit it.  This fixes a problem where the user supplies an invalid
	process ID which is > 0 which results in the PID argument not being
	audited.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/kern_sig.c#21 (text+ko) ====

@@ -1693,6 +1693,7 @@
 	int error;
 
 	AUDIT_ARG(signum, uap->signum);
+	AUDIT_ARG(pid, uap->pid);
 	if ((u_int)uap->signum > _SIG_MAXSIG)
 		return (EINVAL);
 
@@ -1709,7 +1710,6 @@
 		PROC_UNLOCK(p);
 		return (error);
 	}
-	AUDIT_ARG(pid, uap->pid);
 	switch (uap->pid) {
 	case -1:		/* broadcast signal */
 		return (killpg1(td, uap->signum, 0, 1));


More information about the p4-projects mailing list